Fix tokenizing of comments starting or ending with more than two --#1
Merged
nfrasser merged 1 commit intonfrasser:release-linkify-v4.0.0from May 7, 2025
Merged
Conversation
Comments ending with more than two dashes are not terminated correctly, resulting in markup following these comments to be included. `<!--Comment---><div>Markup</div>` is tokenized as a comment of `Comment---><div>Markup</div>`. Comments starting with three dashes have their first character clipped. `<!---Comment-->` is tokenized as a comment of `omment`.
Author
|
I wasn't sure if master was the right branch to merge into, since the repo had no contribution guidelines. @nfrasser any feedback would be greatly appreciated. |
charlag
approved these changes
May 6, 2025
nfrasser
approved these changes
May 7, 2025
nfrasser
added a commit
to nfrasser/linkifyjs
that referenced
this pull request
May 7, 2025
To include changes from nfrasser/simple-html-tokenizer#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments ending with more than two dashes are not terminated correctly, resulting in markup following these comments to be included.
<!--Comment---><div>Markup</div>is tokenized as a comment ofComment---><div>Markup</div>.Comments starting with three dashes have their first character clipped.
<!---Comment-->is tokenized as a comment ofomment.